Skip to content

Ci #34131 rm slow fixtures #34549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

OlivierLuG
Copy link
Contributor

  • [ x ] Part of CI/TST: slow tests #34131
  • [ x ] passes black pandas
  • [ x ] passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [ FAIL ] tests passed for 11 of 12 files changed. 6 tests fail inside the file pandas/core/arrays/datetimes.py , but there are not concerned by this PR. So I decide to push anyway.

I went through tests tagged with @pytest.mark.slow and take a look at the duration. The test is unmarked if the test duration is below 1 second.
note: I considered the total time for each combination in case of parameters

A total of 76 flags slow were unmark, so we can focus on "real" slow tests.

@jbrockmendel
Copy link
Member

for future reference, lets refer to these as pytest.mark.slow, since they're not technically fixtures

@jbrockmendel
Copy link
Member

looks like some of the failing tests need a td.skip_if_no_scipy decorator

@jreback
Copy link
Contributor

jreback commented Jun 3, 2020

@OlivierLuG aplaud the effort here. this is a bit tricky because IIRC we only run the slow on a single job (on travis); the issue is that some of these tests are marked slow not to indicate they are slow but rather that we want to run them there, e.g. plotting tests and such.

we have a pretty tricky setup with this, so you will have to play with the ci to get this to pass.

you might want to start with a smaller scope (e.g. start with x tests), then get it passing, then keep adding.

@jreback jreback added CI Continuous Integration Testing pandas testing functions or related to the test suite labels Jun 3, 2020
@OlivierLuG
Copy link
Contributor Author

Thanks for the explaination. If I do understand correctly, the objective of this issue is either to unmark the slow tests, and still passing the CI tests or to optimise the speed of the tests itself ?

@jreback
Copy link
Contributor

jreback commented Jun 4, 2020

i think a good start here would be to fix some of the really slow tests themselves

also the original issue was about some fast tests that are actually slow on ARM

@OlivierLuG OlivierLuG closed this Jun 7, 2020
@OlivierLuG OlivierLuG deleted the CI_#34131_rm_slow_fixtures branch June 7, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants